-
Notifications
You must be signed in to change notification settings - Fork 102
Bump @nextcloud/vue from 1.5.0 to 3.5.4 #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #561 +/- ##
========================================
Coverage 1.01% 1.01%
Complexity 440 440
========================================
Files 13 13
Lines 1381 1381
========================================
Hits 14 14
Misses 1367 1367
Flags with carried forward coverage won't be shown. Click here to find out more. |
9d3483b to
f716300
Compare
Bumps [@nextcloud/vue](https://github.com/nextcloud/nextcloud-vue) from 1.5.0 to 3.5.4. - [Release notes](https://github.com/nextcloud/nextcloud-vue/releases) - [Changelog](https://github.com/nextcloud/nextcloud-vue/blob/master/CHANGELOG.md) - [Commits](nextcloud-libraries/nextcloud-vue@v1.5.0...v3.5.4) Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
…to current nextcloud-vue library Signed-off-by: Sebastian Fey <[email protected]>
…er of recipes next to categories in category-edit mode Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
f716300 to
8fa6bd0
Compare
|
I made several changes to accommodate for the new version which had some breaking changes. While being at it, I split off the settings in the navigation pane to a separate component since it had become rather large. For some reason editing the category name now doesn’t show the current name anymore - I have no idea why. This might be a bug in the new library version but probably has a different reason. While looking at this, I also added a loading indicator which is shown while the categories in the navigation panel are fetched. @christianlupus any comments? |
christianlupus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and we are up to date with the NC development again.
No it is a bug. I looked into it and I will open a PR/issue against the library after this comment. So we will have to wait for their fix. Update: |
Bumps @nextcloud/vue from 1.5.0 to 3.5.4.
Release notes
Sourced from
@nextcloud/vue's releases.... (truncated)
Changelog
Sourced from
@nextcloud/vue's changelog.... (truncated)
Commits
97d23023.5.4fb1c7b4Update changelog for 3.5.4ab6b0f9Merge pull request #1620 from nextcloud/dependabot/npm_and_yarn/cypress-visua...7753cc1Bump cypress-visual-regression from 1.5.5 to 1.5.6a272011Merge pull request #1682 from nextcloud/translations_l10n-messages-pot--maste...a94e7fdMerge pull request #1672 from nextcloud/dependabot/npm_and_yarn/webpack-cli-4...7fdb4adMerge pull request #1673 from nextcloud/dependabot/npm_and_yarn/stylelint-13.9.0be1e479Merge pull request #1676 from nextcloud/dependabot/npm_and_yarn/vue-eslint-pa...56e1f8bMerge pull request #1686 from nextcloud/dependabot/npm_and_yarn/vue-styleguid...ee2bf39Merge pull request #1685 from nextcloud/bugfix/1681/revert-tooltip-hack-fix-p...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)